Fixes #25593, addresses comments and updates what's new #25749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, we have a preference of merging the earlier PR and letting the original author respond to reviews. If you are working with @maramiulescu, please work with them to get your commits into their PR branch rather than opening new competing PRs here. If you are not working with them, then please give them an opportunity to respond to reviews. This is the second one of these we have closed. |
|
Hi Kyle,
Thanks for your note. This PR was created as part of an academic project.
While there is no system to “claim” an issue, we had written about and
began working on solving #24404 before @maramiulescu created their PR.
We understand the system in place is to have the original contributor
respond to comments, however we were looking to help out with this issue.
Your feedback on the PR we opened would be greatly appreciated, regardless
if it is merged or not. Apologies for any inconvenience. We have submitted
our project and enjoyed contributing to matplotlib!
Thanks,
ramaini
On Fri, Apr 21, 2023 at 4:07 PM Kyle Sunden ***@***.***> wrote:
In general, we have a preference of merging the earlier PR and letting the
original author respond to reviews. If you are working with @maramiulescu
<https://github.com/maramiulescu>, please work with them to get your
commits into their PR branch rather than opening new competing PRs here. If
you are not working with them, then please give them an opportunity to
respond to reviews. This is the second one of these we have closed.
—
Reply to this email directly, view it on GitHub
<#25749 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX5K2V3ZXB5PKQ4Q7BDIUATXCLSIPANCNFSM6AAAAAAXHH7GAQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Raghav Maini*
Stephen M. Ross School of Business | BBA
Dual Degree with School of Engineering
University of Michigan, Ann Arbor
248.824.0907 | ***@***.***
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst