Skip to content

pie_chart_with_horizontal_bar_chart added #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

pie_chart_with_horizontal_bar_chart added #2578

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 5, 2013

Simple Bar chart with leading horizontal bar chart added to examples/pie_and_polar_charts section.

@tacaswell
Copy link
Member

Can you also add this to the documentation someplace (gallery?)

Please see https://github.com/matplotlib/matplotlib/wiki/MEP12, #2181 and #2474

@tonysyu
Copy link
Contributor

tonysyu commented Nov 8, 2013

I hope this doesn't come off the wrong way, but I don't really understand the point of this example. There are examples for bar charts and pie charts that demonstrate the functionality here, and I don't think combining the two into one plot warrants a new example.

Sorry to be so negative, but I'm of the opinion that the gallery needs to be trimmed down.

@efiring
Copy link
Member

efiring commented Nov 8, 2013

I agree with @tonysu on this.

@ghost
Copy link
Author

ghost commented Nov 8, 2013

The idea behind this example was to add more example to the Library. In my view more example we have the more useful the Library is.
@tonysyu is right with his point of view. The example does not add any new functionality but serve as an another use of this two charts types.

@ghost
Copy link
Author

ghost commented Nov 8, 2013

After reviewing the MEP12 (which @tacaswell suggested) more carefully, not to add this new example to the Library may be more reasonable to keep example sections simple and not to repeat ourselves.
In my opinion, having more and more example is quite important for useful library. On the other hand, examples should be organized carefully for usability and simplicity. ( @tonysyu is right in his point)

So, not to merge this patch will be the best.

@ghost ghost closed this Nov 8, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants