Skip to content

Sketch seed #25796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Sketch seed #25796

wants to merge 6 commits into from

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented May 1, 2023

PR summary

Closes #13479

Rebased the branch from @eudoxos.

Tests and release notes still required.

PR checklist

@oscargus
Copy link
Member Author

oscargus commented May 1, 2023

Anyone can feel free to try to fix the issue here. Not sure I'll get back to it in a while. At least it is rebased, so slightly easier...

@story645 story645 added Difficulty: Medium https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! labels May 1, 2023
@story645
Copy link
Member

story645 commented May 1, 2023

Marking this as good first issue b/c it's building on an existing patch that's rebased against current code & has clear next steps - figure out why the tests aren't passing and make them pass. To work on this you can either copy @oscargus's work or open a pull request against this branch on his fork of matplotlib. You can also suggest solutions as part of reviewing this PR.

@oscargus
Copy link
Member Author

oscargus commented May 2, 2023

The easiest way is probably to create your own branch from this, leading to something like:

git remote add oscargus https://github.com/oscargus/matplotlib.git
git fetch oscargus
git switch -c mybranch remote/oscargus/sketch-seed

(If this is not the correct branch name, check with git branch -v -a.)

@AryanSheka AryanSheka mentioned this pull request Jun 2, 2023
5 tasks
@rcomer
Copy link
Member

rcomer commented Oct 31, 2023

I think this one has been superseded by #26050. Please re-open if I’m mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Medium https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! status: needs rebase status: orphaned PR status: superseded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path randomness is repetitive (sketch RNG seeded to 0 for each path anew)
5 participants