Replace random values by hard-coded numbers in plot-types ... #25797
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for the cases where we have only very few random numbers. This makes the code a bit simpler, because we do not have to seed. Also, a list of hard-coded numbers is slightly simpler to grasp compared to a rng function. This is partly also in anticipation of the switch to numpy's rng generator classes. While conceptually superior, they are a bit more verbose and introduce the additional local variable `rng` (IMHO this is the benefit and the downside: It explicitly ties the rng state to the local context -> clarity. But OTOH the user is bothered with this local state even if it's not important to them - like in our examples.)
story645
approved these changes
May 1, 2023
tacaswell
approved these changes
May 1, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 1, 2023
…bers in plot-types ...
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 1, 2023
…bers in plot-types ...
QuLogic
added a commit
that referenced
this pull request
May 2, 2023
…797-on-v3.7.x Backport PR #25797 on branch v3.7.x (Replace random values by hard-coded numbers in plot-types ...)
QuLogic
added a commit
that referenced
this pull request
May 2, 2023
…797-on-v3.7.1-doc Backport PR #25797 on branch v3.7.1-doc (Replace random values by hard-coded numbers in plot-types ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for the cases where we have only very few random numbers. This makes the code a bit simpler, because we do not have to seed. Also, a list of hard-coded numbers is slightly simpler to grasp compared to a rng function.
The values are chosen so that the figures look approximately the same as before.
This is partly also in anticipation of the switch to numpy's rng generator classes (related: #25765). While conceptually superior, they are a bit more verbose and introduce the additional local variable
rng(IMHO this is the benefit and the downside: It explicitly ties the rng state to the local context -> clarity. But OTOH the user is bothered with this local state even if it's not important to them - like in our examples.)