Skip to content

Fix TransformedBbox.{,full_}contains. #25902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023
Merged

Fix TransformedBbox.{,full_}contains. #25902

merged 1 commit into from
May 22, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 17, 2023

... by checking whether the inverse-transformed the query point is in the untransformed bbox.

Closes #12057.

PR summary

PR checklist

Copy link
Member

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Maybe add a few more points to make the tests are bit more "illustrative"?

... by checking whether the inverse-transformed the query point is in
the untransformed bbox.
@timhoffm timhoffm added this to the v3.7.2 milestone May 22, 2023
@timhoffm timhoffm merged commit f45b423 into matplotlib:main May 22, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 22, 2023
@anntzer anntzer deleted the tbc branch May 22, 2023 06:32
timhoffm added a commit that referenced this pull request May 22, 2023
…902-on-v3.7.x

Backport PR #25902 on branch v3.7.x (Fix TransformedBbox.{,full_}contains.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransformedBbox.contains has less-than-optimal semantics
3 participants