Rewrite offset_copy for better error message #25920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
May 19, 2023
ksunden
approved these changes
May 19, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 19, 2023
rcomer
added a commit
that referenced
this pull request
May 20, 2023
…920-on-v3.7.x Backport PR #25920 on branch v3.7.x (Rewrite offset_copy for better error message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Passing an incorrect unit and no fig gave 'For units of inches or points a fig kwarg is needed' which really didn't make sense.
Will still return a ValueError, but with a more sensible message.
(I know that there are discussions if one should leave the final case out after check_in_list or not, but here it did nothing...)
PR checklist