New layout for qt4 subplottool + QMainWindow -> QDialog #2594
Conversation
|
@tacaswell rebased + use new style qt signals |
|
|
||
| """ | ||
|
|
||
| __author__ = 'rudolf.hoefler@gmail.com' |
There was a problem hiding this comment.
We only have this one other place in the code base, is there a policy on this? @mdboom
There was a problem hiding this comment.
There are 4 occurrences of __author__ in the mpl codebase
examples/api/sankey_demo_old.py:__author__ = "Yannick Copin <ycopin@ipnl.in2p3.fr>"
examples/user_interfaces/interactive.py:__author__ = "Fernando Perez <Fernando.Perez@colorado.edu>"
examples/user_interfaces/svg_histogram.py:__author__="david.huard@gmail.com"
lib/matplotlib/sankey.py:__author__ = "Kevin L. Davies"There was a problem hiding this comment.
I would argue that the examples are not part of the library proper (as they are stand alone examples of using the library)
|
@Thisch Awesome, thanks! I am a little concerned about two non-code things (both of which may be me worrying too much):
|
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
|
@tacaswell: Put @rhoef back into the commit logs (by squashing the #2112 branch) |
|
I just tested this quickly on my machine, and it looks very nice. Just one glitch: the label on the "tight layout" button is misspelled (starts with "th" instead of "t"). |
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
|
@efiring fixed typo |
New layout for qt4 subplottool + QMainWindow -> QDialog
This supersedes the subplottool part from #2112.