Skip to content

Fix get_constrained_layout_pads #25964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2023

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented May 24, 2023

PR summary

  • fix non-existing function get_info()
  • complete docs

closes #25963

PR checklist

- fix non-existing function get_info()
- complete docs
@StefRe StefRe force-pushed the fix/get_constrained_layout_pads branch from 6cb2d8d to 67d1126 Compare May 24, 2023 14:24
@melissawm melissawm added the topic: geometry manager LayoutEngine, Constrained layout, Tight layout label May 24, 2023
@tacaswell tacaswell added this to the v3.7.2 milestone May 24, 2023
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge on green.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic force-pushed the fix/get_constrained_layout_pads branch from d92c1b7 to b45d2c4 Compare May 24, 2023 21:40
@QuLogic
Copy link
Member

QuLogic commented May 24, 2023

Oops, I messed up the types there, should be fixed now.

@QuLogic QuLogic merged commit 1c8975a into matplotlib:main May 25, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented May 25, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1c8975abd03478713c2e4a878fd69629e96c20b9
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25964: Fix get_constrained_layout_pads'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-25964-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #25964 on branch v3.7.x (Fix get_constrained_layout_pads)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request May 25, 2023
@StefRe StefRe deleted the fix/get_constrained_layout_pads branch May 25, 2023 07:38
QuLogic added a commit that referenced this pull request May 25, 2023
…3.7.x

Backport PR #25964 on branch v3.7.x (Fix get_constrained_layout_pads)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fig.get_constrained_layout_pads() raises AttributeError
5 participants