Add setuptools as an explicit build requirement #25973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the [virtualenv user guide](https://virtualenv.pypa.io/en/latest/user_guide.html#seeders): > Installing setuptools and wheel is disabled by default on Python 3.12+ environments. This is just explicitly requiring setuptools that has otherwise been provided by default. While we may be "saved" for a bit longer yet by transitive dependency on setuptools (e.g. via setuptools_scm), better to be explicit. (And even setuptools_scm is likely to drop the dependency, actually, according to @henryiii)
tacaswell
approved these changes
May 24, 2023
QuLogic
approved these changes
May 24, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 25, 2023
rcomer
added a commit
that referenced
this pull request
May 25, 2023
…973-on-v3.7.x Backport PR #25973 on branch v3.7.x (Add setuptools as an explicit build requirement)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
From the virtualenv user guide:
This is just explicitly requiring setuptools that has otherwise been
provided by default. While we may be "saved" for a bit longer yet by
transitive dependency on setuptools (e.g. via setuptools_scm), better to
be explicit. (And even setuptools_scm is likely to drop the dependency,
actually, according to @henryiii)
PR checklist