Added context managers to lockdraw #25987
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
As noted in #24703 (comment) I'm not really sure we want this. |
|
Hello! Alright! I Implemented just in case it was necessary on a further future. |
|
Thanks for the contribution. We will not carry code around that we do not need right now. If we need something later we can always implement it then. The way forward here is to check the call sites of the lock whether it can actually be applied as the context manager in our code (as proposed in #24703 (comment)). If there are such cases, this PR should rewrite them. If not, my assumtion that a context manager is useful was wrong. |
|
Closing as it’s not clear this is actually helpful. See the discussion in the original issue. Sorry for setting a wrong track. |
PR summary
closes #24703
Implemented enter and exit on LockDraw class following the suggestion made in the issue.
PR checklist