Skip to content

Document that GridSpec.get_subplot_params ignores gridspec.figure. #25992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 28, 2023

It may not be the nicest API, but let's at least document it.

Closes #13109.

PR summary

PR checklist

It may not be the nicest API, but let's at least document it.
@anntzer anntzer added Documentation topic: geometry manager LayoutEngine, Constrained layout, Tight layout labels May 28, 2023
@rcomer rcomer added this to the v3.7.2 milestone May 28, 2023
@rcomer
Copy link
Member

rcomer commented May 28, 2023

Merging with test failures as they are clearly unrelated (and showing up elsewhere).

@rcomer rcomer merged commit 86e544a into matplotlib:main May 28, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 28, 2023
rcomer added a commit that referenced this pull request May 28, 2023
…992-on-v3.7.x

Backport PR #25992 on branch v3.7.x (Document that GridSpec.get_subplot_params ignores gridspec.figure.)
@anntzer anntzer deleted the gsf branch May 28, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_subplot_params behavior doesn't match docstring
2 participants