Skip to content

Improve Qt compatibility #26052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2023
Merged

Improve Qt compatibility #26052

merged 3 commits into from
Jun 3, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 3, 2023

PR summary

This makes some minor tweaks to avoid some issues that were caused by PyQt6 6.5.1. However, that version is broken on Ubuntu 20.04, so after confirming that this will fix these things, I will add a skip for it too.

PR checklist

QuLogic added 2 commits June 2, 2023 21:08
@QuLogic
qt: Merge window closing event handlers
a09ddb8 
This will technically fix the tests with PySide6 6.5.1, but there are
other issues with tool manager, so we won't unpin that.
@QuLogic
qt: Avoid setting Qt5 attributes on Qt6
6488491 
In some versions, this appears to emit a deprecation warning, so don't
even attempt it.
@QuLogic QuLogic added the GUI: Qt label Jun 3, 2023
@QuLogic QuLogic added this to the v3.7.2 milestone Jun 3, 2023
@QuLogic QuLogic force-pushed the improve-qt branch 2 times, most recently from 1cc4121 to 6488491 Compare June 3, 2023 01:53
@ksunden ksunden mentioned this pull request Jun 3, 2023
Merged
@QuLogic
Copy link
Member Author

QuLogic commented Jun 3, 2023

However, that version is broken on Ubuntu 20.04, so after confirming that this will fix these things, I will add a skip for it too.

To be specific on this, the QtGui shared library links to a hypotf@GLIBC_2.35 symbol, but is in a manylinux_2_28 wheel (suggesting glibc 2.28 compatibility.) And Ubuntu 20.04 uses glibc 2.31, so doesn't have that symbol.

@QuLogic
ci: Skip PyQt6 6.5.1 wheels
89fb6d4 
They are linked to a symbol from glibc 2.35, while claiming to be for
2.28, and Ubuntu 20.04 only has 2.31.
@QuLogic QuLogic marked this pull request as ready for review June 3, 2023 03:21
@ksunden
Copy link
Member

ksunden commented Jun 3, 2023

Is there even a good place to report such a bug upstream? email support@riverbankcomputing.com, perhaps? (That's how they expect patches to be submitted...)

There is no public bug tracker as far as I can tell

@QuLogic
Copy link
Member Author

QuLogic commented Jun 3, 2023

I sent an email to their mailing list; it doesn't show up in their archive, but I also didn't get a bounce. It didn't say you needed to subscribe, but maybe non-members need to go through moderation.

@ksunden ksunden mentioned this pull request Jun 3, 2023
Closed
@oscargus oscargus merged commit 6241384 into matplotlib:main Jun 3, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 3, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 3, 2023
@oscargus @meeseeksmachine
Backport PR matplotlib#26052: Improve Qt compatibility
ac9fe58
@QuLogic QuLogic deleted the improve-qt branch June 5, 2023 19:20
QuLogic added a commit that referenced this pull request Jun 5, 2023
@QuLogic
Merge pull request #26055 from meeseeksmachine/auto-backport-of-pr-26…
5958e32 
…052-on-v3.7.x

Backport PR #26052 on branch v3.7.x (Improve Qt compatibility)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
GUI: Qt
Projects
None yet
Milestone
v3.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @ksunden @oscargus