Correct bounding box calculation for text markers #26101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Points with `CLOSEPOLY` or `STOP` codes have vertex values that are meaningless, but the marker bounding box calculation still counts them. This causes several markers to not be correctly centred as expected. Fixes matplotlib#26083
|
This is what the example from #26083 provides with the change (copying here for reference):
|
ksunden
approved these changes
Jun 10, 2023
oscargus
approved these changes
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Points with
CLOSEPOLYorSTOPcodes have vertex values that are meaningless, but the marker bounding box calculation still counts them. This causes several markers to not be correctly centred as expected.Fixes #26083
PR checklist