Skip to content

Getting numeric value from unit registry on imshow function #26104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Getting numeric value from unit registry on imshow function #26104

wants to merge 2 commits into from
+12 −0

Conversation

lucavribeiro
Copy link

PR summary

closes #25062

With this it would be possible to pass unit-ful data as vmin/vmax parameters on imshow function

PR checklist

@lucavribeiro lucavribeiro marked this pull request as draft June 10, 2023 19:11
@ksunden
Copy link
Member

ksunden commented Jun 13, 2023

This is a fairly restricted definition of "unitful" data, and not one that we use anywhere else in matplotlib.

If we were to do this, I think it would have to be a full matplotlib.units support.

@thiagoluisbecker
Copy link
Contributor

@ksunden Something like that would make a fit for this issue?
Captura de tela 2023-07-04 161829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
New feature status: needs rebase topic: units and array ducktypes
Projects
First Time Contributors
Status: Needs decision
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH]: Ability to set imshow vmin/vmax with units
4 participants
@lucavribeiro @ksunden @thiagoluisbecker @melissawm