Skip to content

Doc user guide cards #26105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Doc user guide cards #26105

merged 5 commits into from
Jun 15, 2023

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jun 11, 2023

PR summary

This organizes the ToC for https://matplotlib.org/devdocs/users/index.html using grids and adds a rotator for images in a couple of the shorter grids.

I changed the ToC depth for things that already have top-level nabber links as those are prominent enough.

Current:

Current

Proposed. EDIT: newest version

New

PR checklist

@jklymak jklymak force-pushed the doc-user-guide-cards branch from 8c3b14b to a4c51c9 Compare June 11, 2023 04:26
@jklymak
Copy link
Member Author

jklymak commented Jun 11, 2023

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is overall great!

faq/index.rst
resources/index.rst
../api/index.rst
../devel/index.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go into the information card? It feels out of place in the reference/example card.

explain/index.rst
faq/index.rst
resources/index.rst
../api/index.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go at the end of this list?

../devel/index.rst
project/index.rst
release_notes.rst
release_notes.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on the top level, so I think making it two levels is kinda cluttering it here.

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major improvement - couple of suggestions that are more take or leave. I just think this probably needs two approvals since it's a bigger change.

getting_started/index.rst
installing/index.rst
faq/index.rst
resources/index.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the other stuff, I think this should also be moved to maybe the tutorials/plot types/example section as it's I think mostly external tutorials and tools & probably overkill for a get started.


.. raw:: html

<div class="grid__intro" id="image_rotator"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, would the anatomy image/a semi stripped down form be a good anchor or intimidating? I generally really like the idea of anchoring these two sections with images, but for this one in particular think maybe a single explanatory image may make more sense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, would the anatomy image/a semi stripped down form be a good anchor or intimidating?

I think the actual anatomy would be too busy. But I've taken the spirit of this, and added a "simple plot" that has a few lines, and some scatter on it.

@story645
Copy link
Member

Outside of scope here, bit would it make sense maybe to push the rotator out to mpl-sphinx-theme?

@story645
Copy link
Member

Outside of scope here, bit would it make sense maybe to push the rotator out to mpl-sphinx-theme?

Eta: also this is gonna make me sound super indecisive but now I think resources should maybe be moved back and the FAQ moved out somewhere, but I think that's probably cause scope is a bit fuzzy.

@jklymak
Copy link
Member Author

jklymak commented Jun 11, 2023

Outside of scope here, bit would it make sense maybe to push the rotator out to mpl-sphinx-theme?

Eta: also this is gonna make me sound super indecisive but now I think resources should maybe be moved back and the FAQ moved out somewhere, but I think that's probably cause scope is a bit fuzzy.

I think the organization could go many ways, but I think it's fair to think of the External Resources as more "Examples and Tutorials", which they largely are. FAQ and troubleshooting in the top card also makes sense to me as something folks need quite often. We can always try this for a while and then follow up.

@tacaswell tacaswell added this to the v3.8.0 milestone Jun 15, 2023
@story645 story645 merged commit 704c7d8 into matplotlib:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants