Stop building universal2 and win32 wheels #26125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, minor typo in the docs, but I'll fix that after the call tomorrow. |
Upstream `contourpy` has stopped building these wheels in their latest 1.1.0 release. Partially, this was because they thought we did, but also because NumPy will for 2.0, and it's more difficult to do with Meson. As we shall also be porting to Meson, we might as well turn this off too.
NumPy never built these, and now has a pretty good explanation of why individual packages should not be doing it, as opposed to app bundling systems. See numpy/numpy#20787 (comment) and following comments.
tacaswell
approved these changes
Jun 15, 2023
ksunden
approved these changes
Jun 15, 2023
|
Circle timed out during uploading artifacts, but built successfully (though cannot view preview without artifacts) MacOS on azure is problematic for unrelated Tk reasons This is a change to only docs and github actions, so I'm going to go ahead and merge before Azure/appveyor complete (especially as this should fix CI on main... though not completely because of the MacOS Tk thing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Upstream
cibuildwheeldropped wheels for these systems. There are some good arguments for that related to support from NumPy (who has no universal2 wheels and will drop win32 soon) to ease of cross-compile with Meson (which we'll be porting to soon.)This is up for discussion in the dev meeting tomorrow.
PR checklist