-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fixing Bug with RGB photos in imshow using alpha array-type #26144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution @NikosNikolaidis02! Please could you have a look through the checklist in the PR summary above and also the pull request guidelines in the developers' guide. In particular
I'm going to mark this as "draft" for now. Please mark it as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in our incubator gitter room. |
Hello @rcomer, Thank you for your fast response! I will try to fix these issues in these days, so I would really like your guidelines through the process! |
@rcomer should I ignore the failure on macos? |
That is also a known issue that can be ignored for now. |
So when my pull request will be open to be reviewed? |
At the moment it looks like you only applied the patch from #26092 (comment), but that comment also says that that patch is not the whole solution. To proceed, we would need a complete solution, including new tests to confirm the behaviour is now as we want it. I do not want to discourage you from contributing in Matplotlib but I will note that the issue is marked "medium difficulty". So if you are inexperienced with python or testing, it may be better to choose a different issue to work on initially. |
Ok, thank you! I will try to continue with this issue, but I would appreciate your help on testing on which I am unexperienced. |
We have guidance about writing tests here: But I also see from #26092 (comment) that the current change
So there is probably also still more to do in the main code. |
Hi @NikosNikolaidis02 I’m guessing you decided not to pursue this PR since you opened one for a different issue. So I’m going to close it so it’s more obvious to others that they can work on it. If you are still interested in working on this, please do comment and we can re-open. |
PR summary
"
This pull request tries to ressolve issue #26092
I've tried to added the proposal solution of @tacaswell , but I would like your feedback what else I should try to include to ressolve this issue.
"
PR checklist