precommit warns on main + instructions for fix #26171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jun 23, 2023
|
😅 you're welcome to take over |
greglucas
reviewed
Jun 23, 2023
1384342 to
28d6a26
Compare
|
do not love that this is running away from me/growing in scope, but since it is are there any other branches that I should include? (like doc or whatever) or is main the only one that's a problem. |
|
So this pr now has: |
8631d19 to
34d8fc3
Compare
greglucas
reviewed
Jun 24, 2023
617c465 to
df6331d
Compare
greglucas
approved these changes
Jun 25, 2023
+ instructions for fix in docs Co-authored-by: Greg Lucas <greg.m.lucas@gmail.com> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a branch protect rule to the pre-commit so that it complains if you try to commit directly to main. I figure folks who really need to push to main also know how to work around it. based on convo in call w/ @greglucas
Not quite sure this is the best way to handle the error message but figure we need to give folks a fix.
Is a replacement for #26170 which I'm not sure how I accidentally created directly on the repo.