Avoid deprecated typing hints #26212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were all deprecated in Python 3.9 by PEP 585 and Generic Alias types (i.e., stuff like `typing.List` -> `list`).
tacaswell
approved these changes
Jun 29, 2023
ksunden
approved these changes
Jun 29, 2023
|
Early test failures (Azure Linux) were apt dependency installs, unrelated. I'll let the others finish I guess, but since this is about type hints Inclined to not bother rerunning those. (though does touch pyplot, so not totally isolated from run-time behavior) |
|
So anyone can merge on CI completion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
These were all deprecated in Python 3.9 by PEP 585 and Generic Alias types (i.e., stuff like
typing.List->list).Note,
Hashable, andSizedare not deprecated, but they are aliases, so I moved them as well.PR checklist