Use CLOSEPOLY kind code to close tricontourf polygons #26226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25114.
Previously polygons generated by
tricontourf
have finished with a kind code of2
(MOVETO
) rather than79
(CLOSEPOLY
). This wasn't a problem for rendering but was for people doing something with the generated paths such as usingto_polygons()
.The fix is to ensure that polygons generated by
tricontour
andtricontourf
have their last vertex identical to their first vertex, and the correctCLOSEPOLY
code. This is the same as that produced bycontour
andcontourf
.Simple reproducer:
Before the fix this gives
and after the fix
(Edited to avoid using deprecated API)