Skip to content

backend_qt4agg: remove redundant classes. Closes #1151. #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2013

Conversation

efiring
Copy link
Member

@efiring efiring commented Nov 30, 2013

No description provided.

@tacaswell
Copy link
Member

The _get_canvas function should also be removed from backend_qt.NavigationToolbar2QT as it is never used.

It looks like it got copied over from the gtk backends when the QT ones were created. In gtk this function is used to set up the subplot tool.

travis failures look to all be pep8 blank-line issues.

efiring added a commit that referenced this pull request Nov 30, 2013
backend_qt4agg: remove redundant classes.  Closes #1151.
@efiring efiring merged commit f226149 into matplotlib:master Nov 30, 2013
@efiring efiring deleted the qt4agg_remove_unneeded branch November 30, 2013 18:30
@tacaswell
Copy link
Member

This probably should get an entry in api_changes.

Do we want to provide an alias to support 3rd party users who might be using it?

@tacaswell tacaswell mentioned this pull request Dec 5, 2013
9 tasks
@efiring
Copy link
Member Author

efiring commented Dec 5, 2013

@tacaswell, good point that it should have an api_changes entry; but I hope we can avoid putting in aliases.

@tacaswell
Copy link
Member

never mind, I can't read.

@tacaswell
Copy link
Member

Sorry for the noise, I miss read.

@tacaswell
Copy link
Member

And I was looking at the wrong example. We do use it in an example, http://matplotlib.org/examples/user_interfaces/embedding_in_qt4_wtoolbar.html , at least the toolbar should be depreciated gracefully.

@efiring
Copy link
Member Author

efiring commented Dec 10, 2013

@tacaswell Thanks for catching that; I was too hasty with the original PR. Both classes can be deprecated by subclassing, using warnings.warn with a mplDeprecation argument in the init. It doesn't look like we have anything fancier than this for deprecating classes.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Dec 12, 2013
Added NavigationToolbar2QTAgg back with a deprecation warning

Added entry to api_changes.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants