Get correct renderer for axes_grid1 inset axes with bbox_inches=tight #26291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
approved these changes
Jul 12, 2023
jklymak
approved these changes
Jul 12, 2023
|
Should this be marked 3.8 or 3.7.3 (and therefore backported)? |
|
I can’t see any harm in backporting. @meeseeksdev backport to v3.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 13, 2023
…et axes with bbox_inches=tight
oscargus
added a commit
that referenced
this pull request
Jul 13, 2023
…291-on-v3.7.x Backport PR #26291 on branch v3.7.x (Get correct renderer for axes_grid1 inset axes with bbox_inches=tight)
xylar
added a commit
to xylar/MPAS-Analysis
that referenced
this pull request
Jul 16, 2023
There is a bug with tight layouts and insets matplotlib/matplotlib#26291
xylar
added a commit
to xylar/polaris
that referenced
this pull request
Jul 27, 2023
We don't want to use version 3.7.2 because of a known bug with tight layouts and insets: matplotlib/matplotlib#26291
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #26287
Adds the plumbing to thread through the renderer from the axes to the calls which need it.
Added a test which fails on current main, but simply smoke tests that it doesn't raise (saving with bbox_inches=tight to a BytesIO)
PR checklist