Add custom_bar_plot() function #26310
Conversation
formatted the setup.py code a bit
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks for the PR, but what you've done here is add another example to one of our galleries rather than implement a new plotting method. The plot type gallery is very heavily curated to only show a subset of plotting methods that are implemented on the axes object, and the bar for getting a new plotting function is very high; therefore, this PR is not gonna make it in as is. ETA: the reason we're unlikely to accept this as a new plotting method, even with heavy revision, is because this is modifying one aspect of a bar chart and not something conceptually distingushable enough to warrant a whole new API. ETA2: potentially there's an argument for making bar color behave more like scatter color (which allows for single color, list of color, and colormapped values) but that would require standalone discussion. But, what I think what you're demonstrating here is something folks ask about somewhat frequently, and so could potentially be a good addition/subsection of the bar color demo So, to get this PR to something that I think could go in:
|
|
It looks like this is superseded by #26314, so I will close it. Please comment and/or re-open if I have that wrong. |
|
can you help me in passing all the checks..I am not getting that part. |
Add custom_bar_plot() function
The custom_bar_plot() function allows for creating bar plots with custom colours for each bar. It provides flexibility in customizing the appearance of bar plots by accepting arrays of labels, values, and optional colours.
The function includes proper documentation with docstrings and follows the Matplotlib coding style.
PR summary
PR checklist