Skip to content

Crash on saving figure if text.usetex is True #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2014
Merged

Crash on saving figure if text.usetex is True #2635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eff9217
Don't free a font that hasn't been created
mdboom Dec 2, 2013
ec2212e
Don't clear glyphs if the face was never created.
mdboom Dec 2, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/ft2font.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,7 @@ PYCXX_NOARGS_METHOD_DECL(FT2Font, get_path)

FT2Font::FT2Font(Py::PythonClassInstance *self, Py::Tuple &args, Py::Dict &kwds) :
Py::PythonClass<FT2Font>(self, args, kwds),
face(NULL),
image()
{
FT_Open_Args open_args;
Expand Down Expand Up @@ -975,11 +976,13 @@ FT2Font::~FT2Font()
{
_VERBOSE("FT2Font::~FT2Font");

FT_Done_Face(face);
if (face) {
FT_Done_Face(face);

for (size_t i = 0; i < glyphs.size(); i++)
{
FT_Done_Glyph(glyphs[i]);
for (size_t i = 0; i < glyphs.size(); i++)
{
FT_Done_Glyph(glyphs[i]);
}
}
}

Expand Down