Skip to content

Rcparam ng proposal (don't merge) #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Rcparam ng proposal (don't merge) #2637

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8b0f5aa
Set default values of kwargs on the fly
tacaswell Dec 2, 2013
5963b00
Added a class to manage collecting/applying the kwarg dictionaries.
tacaswell Dec 2, 2013
c2f6125
made json dumped files human readable
tacaswell Dec 2, 2013
d14d498
pep8 fixes
tacaswell Dec 2, 2013
8bd3a27
made wrapped function override kwarg values of `None`
tacaswell Dec 13, 2013
ce6a8cf
fixed logic as @tonysyu pointed out
tacaswell Jan 16, 2014
fb1fdf7
Move configuration class
tonysyu Jan 17, 2014
8caa77d
Add parsing functions to transform user-config to mpl-config
tonysyu Jan 17, 2014
a3a1083
Connect MPLConfig to user-config parser
tonysyu Jan 17, 2014
e0eee67
Fix class check.
tonysyu Jan 17, 2014
8b75830
Merge pull request #4 from tonysyu/rcparam_ng
tacaswell Jan 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix class check.
  • Loading branch information
@tonysyu
tonysyu committed Jan 17, 2014
commit e0eee67a370b5e4d1e962a50779a47395374327c
3 changes: 2 additions & 1 deletion lib/matplotlib/config/mpl_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import six
from collections import namedtuple, defaultdict
from copy import copy
import inspect
import json

from functools import wraps
Expand Down Expand Up @@ -172,7 +173,7 @@ def string_to_class(klass):
raise_invalid_class_path_error(split_klass)
last_level = getattr(last_level, _k)

if not isinstance(last_level, object):
if not inspect.isclass(last_level):
raise_invalid_class_path_error(split_klass)

return last_level
Expand Down