Skip to content

Update README.txt #26370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Update README.txt #26370

merged 3 commits into from
Jul 25, 2023

Conversation

randomrahulm
Copy link
Contributor

@randomrahulm randomrahulm commented Jul 22, 2023

Added a link to plot_types

PR summary

Add a sentence to the top of the example gallery page (which is galleries/examples/README.txt) pointing to the plot types gallery, something like

closes #26369

PR checklist

Added a link to plot_types
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
The docs still aren't building correctly. You can always see the built docs using this link in the checks panel:
image

https://output.circle-artifacts.com/output/job/3213b654-c4d4-44af-a65e-2daa05f0df92/artifacts/0/doc/build/html/gallery/index.html

added the line under examples
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, we hope to see you again!

@story645 story645 modified the milestones: v3.8.0, v3.7-doc Jul 25, 2023
@story645 story645 added the Documentation: examples files in galleries/examples label Jul 25, 2023
@story645 story645 modified the milestones: v3.8.0, v3.7-doc Jul 25, 2023
@story645 story645 merged commit 6fba64a into matplotlib:main Jul 25, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 25, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 25, 2023
ksunden added a commit that referenced this pull request Jul 25, 2023
…370-on-v3.7.x

Backport PR #26370 on branch v3.7.x (Update README.txt )
ksunden added a commit that referenced this pull request Jul 25, 2023
…370-on-v3.7.2-doc

Backport PR #26370 on branch v3.7.2-doc (Update README.txt )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples
Projects
Development

Successfully merging this pull request may close these issues.

[Doc]: add link to plot types gallery to gallery
2 participants