Skip to content

Update LICENSE_COLORBREWER #26383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pchestek
Copy link

Adds additional clarification found on the author's information page about the license for the software.

PR summary

PR checklist

Add additional clarification found on the author's information page for the software
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell
Copy link
Member

tacaswell commented Jul 24, 2023

Documenting my reasoning from #26361 I did not include this portion of the text because:

From the indentation of section 4 of http://www.personal.psu.edu/cab38/ColorBrewer/ColorBrewer_updates.html I read that the License is the first indented block and the rest of the text (above and below) as commentary. I read "remains in place" as "retained for historical reference on this website", not "appended to the License".

The github repo behind the https://colorbrewer2.org only carries an unmodified Apache 2.0 license (axismaps/colorbrewer#17 / https://github.com/axismaps/colorbrewer/blob/master/LICENCE.txt (which given they did not fill in the template may be its own problem but if it is I do not think is my problem) )

Finally, the stated intent of the change was to avoid a claimed incompatibility with the GPL which, per my understanding of the FSF's claims, is due to the restricitons on the use of names (https://www.gnu.org/licenses/license-list.en.html#apache1.1 ). Appending the Apache v1.1 license to the v2.0 version would defeat the stated intention.


I should note that I am not a Lawyer and @pchestek is (trying to sort out who I was talking to I believe she is https://opensource.org/board-member/pamela-chestek-2/).

@pchestek Are you opening this PR as yourself or on behalf of a client?


[Edited to fix miss-pasted link]

@jklymak jklymak added the status: needs clarification Issues that need more information to resolve. label Jul 27, 2023
@jklymak
Copy link
Member

jklymak commented Oct 8, 2023

@tacaswell, should we close this?

@timhoffm
Copy link
Member

timhoffm commented Feb 2, 2025

Following @tacaswell’s argument and no opposing comments, I’m going to close this.

@timhoffm timhoffm closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance status: needs clarification Issues that need more information to resolve.
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

5 participants