setupext: support using environment variables for dependencies #26679
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
FWIW, before I go and write docs for this, I'd like to know that it's a suitable solution to the problem. If needed, the |
|
Looks like there are some related failures in CI - @mathstuf would you take a look? Let us know if you need help. Thanks! |
On Windows, without Conda or the libraries being in default locations,
matplotlib has problems finding freetype and qhull. Add ultimate
fallback solutions using very specific environment variables named
`{FREETYPE,QHULL}_{INCLUDE,LIBRARY}_DIRS`.
108e0e2 to
3ca43b8
Compare
|
Whoops, indeed. I had typos and copy pasta that I had fixed in testing but had inconsistently applied back to my development machine. Applied here too now. |
|
That would be suitable to me if |
|
Seems to be obsolete since #26621 removed |
It should be; we don't have any platform-specific checks for dependencies, just the standard |
|
Will know the next time we go and bump packages. Thanks :) . |
PR summary
On Windows, without Conda or the libraries being in default locations, matplotlib has problems finding freetype and qhull. Add ultimate fallback solutions using very specific environment variables named
{FREETYPE,QHULL}_{INCLUDE,LIBRARY}_DIRS.My attempts at using
CLandLINKwere failing; not sure if the migration tomesonmade these obsolete or not.PR checklist