Fix flaky CI tests #26680
Merged
Fix flaky CI tests #26680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Sep 2, 2023
| assert x == ',$\\mathdefault{,0{,}5},$' | ||
|
|
||
|
|
||
| def test_locale_comma(): |
There was a problem hiding this comment.
Can you explain this song and dance?
There was a problem hiding this comment.
Yes, it's in the commit message:
On some systems/pytest versions, the skip in an exception handler does not skip, but is treated as an exception. Namely, the ARM test machine in Cirrus and on my WSL Ubuntu.
I assume that is a bug somewhere in pytest but the subprocess avoids that. Also, changing the locale is a global modification, and it seems safer to do so in a subprocess, and not have to worry about fixing it up in the main process.
There was a problem hiding this comment.
Perhaps comment the code as well? This seems an odd thing to do.
On some systems/pytest versions, the skip in an exception handler does not skip, but is treated as an exception. Namely, the ARM test machine in Cirrus and on my WSL Ubuntu.
The main parent process is using Agg, so the subprocess should as well, to be able to unpickle correctly.
d0988c0 to
02263d2
Compare
ksunden
approved these changes
Sep 2, 2023
jklymak
approved these changes
Sep 2, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 4, 2023
ksunden
added a commit
that referenced
this pull request
Sep 4, 2023
…680-on-v3.8.x Backport PR #26680 on branch v3.8.x (Fix flaky CI tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
I've pulled these out of #24597 as that is taking some time to be merged, and it seems like these are failing more often now. Some of these were also triggered on #26621 (while it had bugs) as well.
PR checklist