Skip to content

Update PR template doc links #26684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Sep 3, 2023

PR summary

Looks like documentation guidance has been updated more recently than the PR template. The links are currently all getting redirected to the top of the doc guidance page.

PR checklist

@rcomer rcomer added this to the v3.9.0 milestone Sep 3, 2023
@jklymak
Copy link
Member

jklymak commented Sep 3, 2023

I'd just have one link to the dev guide. This wall of text is probably not read by anyone.

@rcomer
Copy link
Member Author

rcomer commented Sep 3, 2023

I think the checklist is useful: I certainly paid attention to it when I opened my first PR here, and I still sometimes need the reminder to add a versionadded directive. I’m not sure I ever really noticed the long comment below the checklist though.

@timhoffm timhoffm merged commit 42336be into matplotlib:main Sep 3, 2023
@rcomer rcomer deleted the pr-template-doc-links branch September 27, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants