Skip to content

Bump minimum NumPy version to 1.23 #26800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

oscargus
Copy link
Member

PR summary

I take it that we will stick with 1.22 for MPL 3.9. Probably we could have gone to 1.23, but I recall that we are a bit conservative here: https://numpy.org/neps/nep-0029-deprecation_policy.html

PR checklist

@oscargus oscargus added Maintenance PR: dependencies Pull requests that update a dependency file labels Sep 17, 2023
@oscargus oscargus added this to the v3.9.0 milestone Sep 17, 2023
@oscargus oscargus added the CI: Run cygwin Run cygwin tests on a PR label Sep 17, 2023
@oscargus oscargus force-pushed the numpy122bump branch 5 times, most recently from ffc43e7 to 5366eab Compare September 17, 2023 13:17
@oscargus
Copy link
Member Author

Seems like it is not trivial to install numpy 1.26 (probably because of Meson) on CygWin (hence, the pinning in the install step). However, since build isolation is used, it will try to reinstall an unpinned version.

The minver test is probably related, although I cannot really find anything specific in the 1.22 release notes that seems related. The PR that introduced the failing test is: #26253

@oscargus oscargus mentioned this pull request Sep 18, 2023
4 tasks
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Sep 27, 2023
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Sep 27, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Oct 3, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull request Oct 3, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
issamarabi pushed a commit to issamarabi/matplotlib that referenced this pull request Oct 5, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
Vashesh08 pushed a commit to Vashesh08/matplotlib that referenced this pull request Oct 6, 2023
Cherry-picked out of matplotlib#26800; also unpin setuptools.
@oscargus
Copy link
Member Author

oscargus commented Oct 15, 2023

Seems like there are two floating-point related errors with 1.22. Since these are really small, should I just add a bit of tolerance (and a note that these are for NumPy 1..2)?

An option is, I guess, to try 1.22.1 etc to see if this is a regression that was fixed. (Have checked the change log briefly, but not really sure what the underlying problem is anyway...)

@QuLogic
Copy link
Member

QuLogic commented Oct 16, 2023

I've had to bump tolerance on at least one of those failing tests in Fedora fedora-python@d429c3d (though I cheated a little bit and put it in the non-x86 commit). I think it's likely to be the SIMD optimization issue that we've run into with newer NumPy.

@github-actions github-actions bot added Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users and removed CI: Run cygwin Run cygwin tests on a PR status: needs rebase labels Feb 9, 2024
@QuLogic
Copy link
Member

QuLogic commented Feb 9, 2024

We discussed on the call today and decided to go directly to 1.23, so I've pushed that, and also updated the missed pyproject.toml.

@QuLogic QuLogic changed the title Bump minimum NumPy version to 1.22 Bump minimum NumPy version to 1.23 Feb 9, 2024
@ksunden ksunden merged commit d2cc4d0 into matplotlib:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users Maintenance PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants