Skip to content

Backport PR #26849 on branch v3.8.x (Bump setuptools required version because of setuptools_scm v8) #26860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #26849: Bump setuptools required version because of setuptools_scm v8

@lumberbot-app lumberbot-app bot added this to the v3.8.1 milestone Sep 21, 2023
@tacaswell
Copy link
Member

I'm 50/50 on actually merging this.

@ksunden
Copy link
Member

ksunden commented Sep 21, 2023

I think we probably need to either merge this or potentially do a pin on setuptools_scm for this branch, otherwise all backport PRs will fail Azure CI, which may make realizing real failures on backport harder.

We could go an alternative route of not pinning but explicitly installing newer setuptools which would unbreak CI but could leave a thorny path for people installing from source on the backport branch (That's one of the main reasons I just pinned on main)

But doing that would not (officially) be a development/version support change on a point release, though in practice there is some added constraint in compatibility (though unfortunately only flagged/enforced at runtime)

@tacaswell
Copy link
Member

I am less worried about the numpy build time issues than I am by overly pinning deps.

This also only matters for source installations?

@QuLogic
Copy link
Member

QuLogic commented Sep 27, 2023

It is breaking CI on other backports: #26939

@ksunden
Copy link
Member

ksunden commented Sep 28, 2023

Yes, it only matters for source installations (but that includes CI)

@efiring efiring merged commit cc2f0e3 into matplotlib:v3.8.x Oct 4, 2023
@efiring
Copy link
Member

efiring commented Oct 4, 2023

Seems very low risk; let's try it, to get things moving again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants