Skip to content

allsegs and allkinds return individual segments #26908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Sep 25, 2023

PR summary

Closes #26863. I think this reinstates the pre-3.8 behaviour. Adapted @jklymak's example from #26863 (comment) into the new test.

PR checklist

@rcomer rcomer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: contour labels Sep 25, 2023
@rcomer rcomer added this to the v3.8.1 milestone Sep 25, 2023
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was dreading digging into the path API to figure this out....

@rcomer
Copy link
Member Author

rcomer commented Sep 25, 2023

I had previous digging around in there when I was fixing Cartopy!

@rcomer
Copy link
Member Author

rcomer commented Sep 25, 2023

Have now opened #26913 for the deprecation question, so linked the original issue here.

@greglucas greglucas merged commit 449cdb7 into matplotlib:main Oct 10, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 10, 2023
@rcomer rcomer deleted the allsegs branch October 10, 2023 06:41
oscargus added a commit that referenced this pull request Oct 10, 2023
…908-on-v3.8.x

Backport PR #26908 on branch v3.8.x (`allsegs` and `allkinds` return individual segments)
@ksunden ksunden mentioned this pull request Nov 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: contour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: ContourSet allsegs and allkinds after #25247
3 participants