Fix incorrect skip check in test_backend_ps. #26955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo in `elif rcParams.get("ps.userdistiller") == "xpdf"`
which effectively always returned False (the correct spelling is
"ps.usedistiller", so the get() call always returned None), which
made the skip check for xpdf never run. Thus, running the test on
a machine without pdftops installed would eventually result in an
ExecutableNotFoundError when matplotlib actually tries to call the
distiller.
To avoid this kind of problems (dict.get hiding typos), directly update
the test-specific settings into the main rcParams, and use normal
brackets to access rcParams entries, as rcParams keys are a fixed set
anyways.
tacaswell
approved these changes
Sep 28, 2023
ksunden
approved these changes
Sep 28, 2023
|
Anyone can merge on CI passing |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 29, 2023
oscargus
added a commit
that referenced
this pull request
Oct 2, 2023
…955-on-v3.8.x Backport PR #26955 on branch v3.8.x (Fix incorrect skip check in test_backend_ps.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in
elif rcParams.get("ps.userdistiller") == "xpdf"which effectively always returned False (the correct spelling is "ps.usedistiller", so the get() call always returned None), which made the skip check for xpdf never run. Thus, running the test on a machine without pdftops installed would eventually result in an ExecutableNotFoundError when matplotlib actually tries to call the distiller.To avoid this kind of problems (dict.get hiding typos), directly update the test-specific settings into the main rcParams, and use normal brackets to access rcParams entries, as rcParams keys are a fixed set anyways.
This broke the mplcairo test suite (where I didn't bother configuring CI to have pdftops installed) so labeling as 3.8.1; "somewhat" release critical (though I guess I could just xfail the test on mplcairo's side instead).
PR summary
PR checklist