Move papersize="auto" deprecation to backend_bases. #26959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Sep 30, 2023
| @@ -867,9 +867,6 @@ def _print_figure( | |||
| # find the appropriate papertype | |||
| width, height = self.figure.get_size_inches() | |||
| if papertype == 'auto': | |||
| _api.warn_deprecated("3.8", name="papertype='auto'", | |||
| addendum="Pass an explicit paper type, 'figure', or " | |||
| "omit the *papertype* argument entirely.") | |||
| papertype = _get_papertype(*orientation.swap_if_landscape((width, height))) | |||
There was a problem hiding this comment.
I would leave a comment about this here, or it might be forgotten when removing the deprecation in 3.10.
There was a problem hiding this comment.
And/or add a comment to the new deprecation site, because that’s where we look at during the removal.
timhoffm
approved these changes
Sep 30, 2023
timhoffm
reviewed
Sep 30, 2023
| @@ -1053,9 +1050,6 @@ def _print_figure_tex( | |||
| self.figure.get_size_inches()) | |||
| else: | |||
| if papertype == 'auto': | |||
| _api.warn_deprecated("3.8", name="papertype='auto'", | |||
There was a problem hiding this comment.
Same thing about a comment here.
This makes it easier for mplcairo (which also outputs PostScript natively) to inherit the deprecation and be able to run the matplotlib test suite both with matplotlib 3.7 (where there should be no warning) and with matplotlib 3.8 (where there should be a warning).
ksunden
approved these changes
Oct 2, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 2, 2023
oscargus
added a commit
that referenced
this pull request
Oct 3, 2023
…959-on-v3.8.x Backport PR #26959 on branch v3.8.x (Move papersize="auto" deprecation to backend_bases.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for mplcairo (which also outputs PostScript natively) to inherit the deprecation and be able to run the matplotlib test suite both with matplotlib 3.7 (where there should be no warning) and with matplotlib 3.8 (where there should be a warning).
PR summary
PR checklist