Remove backend 3.7-deprecated API #26962
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
This looks good, but it needs an API change note for the removals. There's also something in |
I've removed the deprecated methods |
ff6eca4 to
3f84b61
Compare
|
Doc build is failing because of the build system change, should be fixed by rebasing again onto current Also the changelog note wants a newline at the end (this is what is failing pre-commit CI) |
|
hey can i work on this issue |
|
This is not an open issue; it's an open pull request waiting for a reply from the original submitter, @issamarabi. There is no work to be done here unless the original submitter has disappeared (and it's not clear that enough time has passed for that to be the case). |
|
@issamarabi please report back whether you are you planning to continue this work. |
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
…gion_to_string_argb This commit removes two deprecated methods, PyBufferRegion_to_string and PyBufferRegion_to_string_argb, from src/_backend_agg_wrapper.cpp, deprecated since version 3.7. Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
… methods from 3.7 This commit updates the API change notes to reflect the removal of deprecated Python classes and C++ methods. Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
Removed `to_string` and `to_string_argb` methods from `PyBufferRegion_init_type` Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
Co-authored-by: Kyle Sunden <git@ksunden.space>
Update doc format Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Signed-off-by: Issam Arabi <issam@cs.toronto.edu>
36bc45d to
1d45c3d
Compare
|
Sorry about that! |
Co-authored-by: Kyle Sunden <git@ksunden.space>
|
I created several commits to separate distinct changes. I think this will help future coders. I also wouldn't know how to create one commit message that encompasses all the changes I made. |
I think the PR title would be fine as a commit message, though you can also create a multi-line commit message if you want to add more detail. In general, Matplotlib tries to keep commits to a minimum and, while we are not overly strict about that, it would be very unusual for this project to merge 14 separate commits from a single PR. |
|
Thanks @issamarabi! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
This PR addresses the removal of classes that were deprecated in version 3.7. (issue #26865)
Changes:
PsBackendHelperclass which was deprecated since 3.7.ps_backend_helperattribute from the__getattr__class which referenced the now-removedPsBackendHelper.ServerThreadclass which was also deprecated since 3.7.PR checklist