Added info for getting compilation output from meson on autorebuild #27053
Conversation
b258617 to
87faf31
Compare
|
Personally, I think the env-var makes a lot more sense for the "I occasionally want to see the logs" pattern rather than setting it on install. I'm also slightly weary of the "relatively recently" language here, as I don't particularly like putting time-sensitive verbiage in these docs (at least not in the past tense, less worried about things that "will change" and thus the docs need to be updated once it "has changed"), preferring the phrasing which does not make us have to either a) make a judgement call of when it should be removed before it is just untrue to call it "recent" or b) leave it untouched long enough for it to be unequivocally false. The phrasing of "before this commit" will remain true even if there is still a time where it is functionally irrelevant. |
I really hate dealing with environment variables and am frequently going through a whole bunch of shells when working on anything. If I'm working with C++ files then I want the compilation logs in a way where I don't have to remember to set environment variables every time I open a new shell. |
790a2de to
07a86c8
Compare
|
Edited to include the envar, remove recently, and make more explicit what folks should look for to figure out if their branch is meson enabled. |
41d9849 to
5ae036f
Compare
doc/devel/development_setup.rst
Outdated
| re-run the above command. | ||
| This allows you to import your modified version of Matplotlib without having to | ||
| re-install after changing a ``.py`` or compiled extension file. On Windows, you | ||
| may need to :external+meson-python:ref:`vsenv-example`. |
There was a problem hiding this comment.
Why is this generating warnings?
There was a problem hiding this comment.
old headers - @QuLogic flagged this in #26992 (comment)
I'm adding this line b/c the default git install on windows requires MSYS2 but all our dependency instructions are for MSVC, so I figure I'm not gonna be the only one who will run into this issue.
There was a problem hiding this comment.
granted, I'll also go update the dependency instructions since I've got #27058 anyway
There was a problem hiding this comment.
I'm not sure if that's a usual thing right now. On my current-version Git-for-Windows, Git Bash is in MSYS2, but there are no compilers installed.
There was a problem hiding this comment.
Is there any harm in mentioning this as an option? This is 100% a thing I didn't think to think of until you mentioned it, & it's a sentence here.
There was a problem hiding this comment.
The move to troubleshooting seems good.
5ae036f to
792e274
Compare
792e274 to
b3d72d2
Compare
|
Reworked this so:
|
doc/devel/development_setup.rst
Outdated
| re-run the above command. | ||
| This allows you to import your modified version of Matplotlib without having to | ||
| re-install after changing a ``.py`` or compiled extension file. On Windows, you | ||
| may need to :external+meson-python:ref:`vsenv-example`. |
There was a problem hiding this comment.
The move to troubleshooting seems good.
6298493 to
6933b8a
Compare
added force MSVC to troubleshooting added meson-python to intersphinx Co-authored-by: Kyle Sunden <git@ksunden.space> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
6933b8a to
7f631a6
Compare
PR summary
Added a short sentence/command for building with compilation logs enabled cause I figure it's gonna be a commonish need of anyone working with the c-extension files.
PR checklist