Restore default behavior of hexbin mincnt with C provided #27179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
reviewed
Oct 24, 2023
rcomer
approved these changes
Oct 24, 2023
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
tacaswell
approved these changes
Oct 25, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 25, 2023
…nt with C provided
QuLogic
added a commit
that referenced
this pull request
Oct 26, 2023
…179-on-v3.8.x Backport PR #27179 on branch v3.8.x (Restore default behavior of hexbin mincnt with C provided)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #27103
Closes #16865
This changes the default behavior to avoid errors/warnings on empty bins (restoring behavior when mincnt is not specified to that of before v3.8.0).
Additionally corrects the docstring and updates the release notes (retroactively).
A test case has been added to the tests of empty input with
np.max, a function that errors on empty input.PR checklist