Skip to content

FIX: Expand stairs plot-type entry intro #27209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

CouldNot
Copy link
Contributor

PR summary

The stairs/step plot-types are hard to navigate since there aren't any guidelines for the user in the documentation that outline which should be used in different cases. This PR adds a bit of roadmapping by changing the intro in the stairs plot type entry to something that sets expectations for stairs and points to steps when appropriate.

Closes #27194

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@story645 story645 self-assigned this Nov 1, 2023
@story645 story645 added the Documentation: plot types files in galleries/plot_types label Nov 1, 2023
@pat8901
Copy link
Contributor

pat8901 commented Dec 2, 2023

Is this PR still active?

@story645
Copy link
Member

story645 commented Dec 2, 2023

I'm not sure, but the only fix it needs is the flake 8 and a rebase so I'd prefer to finish this one out rather than it get taken over - @CouldNot are you planning to finish this?

@CouldNot
Copy link
Contributor Author

CouldNot commented Dec 2, 2023

Hi, i opened this PR and I’m planning to finish this. Could you give me a rundown of any changes that need to be made? Thanks.

@story645
Copy link
Member

story645 commented Dec 2, 2023

Please fix the flake 8 error (line too long) shown here https://github.com/matplotlib/matplotlib/pull/27209/files
and rebase on to the main branch to resolve the conflict. If you do not know how to rebase, will be glad to help you or do it for you.

@CouldNot
Copy link
Contributor Author

CouldNot commented Dec 4, 2023

Hi, I've opened #27434, please let me know if everything is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Point to step in stairs plot-type entry
4 participants