Skip to content

FIX: Enable interrupts on macosx event loops #27221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2023
Merged

FIX: Enable interrupts on macosx event loops #27221

merged 1 commit into from
Oct 30, 2023

Conversation

greglucas
Copy link
Contributor

PR summary

Follow the same logic with a context manager for the handling of the event interrupts so that we can reuse the logic from the main loop implementation in the start_event_loop function as well.

python -c 'from pylab import *; plot(); show(block=False); pause(5)'

closes #27120

PR checklist

@greglucas
FIX: Enable interrupts on macosx event loops
faddff9 
Follow the same logic with a context manager for the handling
of the event interrupts so that we can re-use the logic from
the main loop implementation in the start_event_loop function
as well.
@greglucas greglucas added this to the v3.9.0 milestone Oct 28, 2023
anntzer
anntzer approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@ksunden
Copy link
Member

ksunden commented Oct 30, 2023

The issue was milestoned as 3.8.1, the PR was milestoned as 3.9, I'll go ahead and merge it now, but do we wish to backport, @anntzer @greglucas?

@ksunden ksunden merged commit 7296abf into matplotlib:main Oct 30, 2023
@anntzer
Copy link
Contributor

anntzer commented Oct 30, 2023

I think 3.9 is fine, this is not a regression but a new feature?

@tacaswell
Copy link
Member

I think we should backport.

@greglucas greglucas deleted the macos-interrupt branch October 30, 2023 18:09
@greglucas greglucas modified the milestones: v3.9.0, v3.8.1 Oct 30, 2023
@greglucas
Copy link
Contributor Author

@meeseeksmachine backport to v3.8.x

@greglucas
Copy link
Contributor Author

@meeseeksdev backport to v3.8.x

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 30, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 30, 2023
@ksunden @meeseeksmachine
Backport PR matplotlib#27221: FIX: Enable interrupts on macosx event …
276e928 
…loops
rcomer added a commit that referenced this pull request Oct 30, 2023
@rcomer
Merge pull request #27227 from meeseeksmachine/auto-backport-of-pr-27…
bd6dd98 
…221-on-v3.8.x

Backport PR #27221 on branch v3.8.x (FIX: Enable interrupts on macosx event loops)
@ksunden ksunden mentioned this pull request Nov 2, 2023
Merged
5 tasks
@anntzer anntzer mentioned this pull request Nov 7, 2023
Merged
5 tasks
@oscargus oscargus mentioned this pull request Dec 14, 2023
Closed
@greglucas greglucas mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
GUI: MacOSX
Projects
None yet
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.

[Bug]: macosx backend pause() cannot be ctrl-c'd
4 participants
@greglucas @ksunden @anntzer @tacaswell