Skip to content

Tagging Example - Tags for multiple figs demo #27236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2023
Merged

Tagging Example - Tags for multiple figs demo #27236

merged 4 commits into from
Nov 2, 2023

Conversation

sp6370
Copy link
Contributor

@sp6370 sp6370 commented Oct 31, 2023 •
edited
Loading

PR summary

This PR adds the tags for the managing multiple figures demo.

https://matplotlib.org/devdocs/gallery/subplots_axes_and_figures/multiple_figs_demo.html

Related: #27235

PR checklist

github-actions[bot]
github-actions bot reviewed Oct 31, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@sp6370 sp6370 changed the title Merge pull request #26851 from esibinga/tag-guidelines Tagging Example Oct 31, 2023
@sp6370 sp6370 changed the title Tagging Example Tagging Example - New Tag for multiple figs demo Oct 31, 2023
@sp6370 sp6370 changed the title Tagging Example - New Tag for multiple figs demo Tagging Example - Tags for multiple figs demo Oct 31, 2023
@melissawm
Copy link
Member

Preview: https://output.circle-artifacts.com/output/job/9364a871-4235-419f-bd9a-41df370149b5/artifacts/0/doc/build/html/gallery/subplots_axes_and_figures/multiple_figs_demo.html#sphx-glr-gallery-subplots-axes-and-figures-multiple-figs-demo-py

@melissawm melissawm added the Documentation: tags tagging examples + proposing new tags label Oct 31, 2023
melissawm
melissawm approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@story645 story645 added this to the v3.9.0 milestone Oct 31, 2023
@story645
Copy link
Member

story645 commented Nov 1, 2023

Thanks for the PR, I just want to bring this to @esibinga's attention b/c of the use of the reference tag. Why did you label this reference?

@sp6370
Copy link
Contributor Author

sp6370 commented Nov 1, 2023

This could act as reference for Multiple figures.

Is there any other specific use case/definition for the tag?

@story645
Copy link
Member

story645 commented Nov 1, 2023

Is there any other specific use case/definition for the tag?

https://matplotlib.org/devdocs/devel/tag_glossary.html

@sp6370
Copy link
Contributor Author

sp6370 commented Nov 2, 2023

Got it! Thanks for the clarification. I will remove the reference tag.

@story645
Copy link
Member

story645 commented Nov 2, 2023

Would you like to squash into one commit or would you like us to do it?

@sp6370
Copy link
Contributor Author

sp6370 commented Nov 2, 2023

@story645 I hope you can do it!

@story645 story645 merged commit f73d048 into matplotlib:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@story645 story645 story645 approved these changes

@melissawm melissawm melissawm approved these changes

Assignees
No one assigned
Labels
Documentation: tags tagging examples + proposing new tags
Projects
First Time Contributors
Status: Merged
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sp6370 @melissawm @story645