webagg: Don't resize canvas if WebSocket isn't connected #27251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If it is still connecting, then we will get an initial resize from Python once it connects. - If it has disconnected, then resizing will clear the canvas and never get anything back to refill it, so better to not resize and keep something visible.
tacaswell
approved these changes
Nov 2, 2023
ksunden
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
When opening
embedding_webagg_sgskip.pyin Firefox, the empty canvas slowly increases in height until the figure first comes through. Skipping the canvas resize until the WebSocket connects prevents this unnecessary canvas change.PR checklist