FIX: allow re-shown Qt windows to be re-destroyed #27313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Qt window is closed we do not strip off the Qt components and it is technically possible to re-show it. However, the latch we use to detect re-entrant destruction does not get reset so the figure can not be re-destroyed.
ksunden
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Seems at the very least more correct, my only concern would be if something gets "destroyed" and "reopened" in quick succession, whether the flag would be set back to "False" too soon? (That would likely mean it is being controlled by different threads (or odd ordering of operations from the qt event loop), for instance, so not sure it is likely to be an actual problem)
Even if it was set back to False befor it got checked, not obvious to me that it would be incorrect, And I have the slight sense that for it to become problematic, it would require in fact going back and forth more than just once, at that.
timhoffm
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Qt window is closed we do not strip off the Qt components and it is technically possible to re-show it. However, the latch we use to detect re-entrant destruction does not get reset so the figure can not be re-destroyed.
More subtle behavior details discovered while working on mpl-gui.