Skip to content

TST: Compress some hist geometry tests #27447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2023
Merged

TST: Compress some hist geometry tests #27447

merged 1 commit into from
Dec 15, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 5, 2023

PR summary

We don't want to replicate the entire calculation from the implementation, or they could both be buggy, but I think this is a reasonable compromise. And using the top/bottom variables make the step/stepfilled difference clearer to me.

PR checklist

@QuLogic
TST: Compress some hist geometry tests
092a400 
We don't want to replicate the entire calculation from the
implementation, or they could both be buggy, but I think this is a
reasonable compromise.
@QuLogic QuLogic added this to the v3.9.0 milestone Dec 5, 2023
@oscargus oscargus merged commit ca946ac into matplotlib:main Dec 15, 2023
@QuLogic QuLogic deleted the fewer-tests branch December 15, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
Maintenance topic: testing
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @ksunden @oscargus