Ok, I've put a lot of comments here. In principle this is fine (I wish we had a "color" class to attach this as a method to, but that is for another day) - I've been rather picky about the PEP8 compliance in this PR, I do apologise, particularly since the file you've modified isn't especially PEP8 compliant in the first place, but we have to start somewhere, right? 😄

Finally, a simple unit test for this would be hugely valuable I think - it doesn't have to be super clever, just a 3 liner to put in a color, lighten it, and check the result.

Thanks @dvreed77 and @tacaswell.

Thanks for the comments. I have some newbie questions that you might be able to help out with. I created this function in a separate file and when it was working the way I wanted it to I copied and pasted it into my github forked repository and pushed it.

My question is, how can I test it while its in place of my forked repository since this version of matplotlib isn't the one that its in my python path.

I tried to insert the github version at index 0 in my python path, but get the following error when trying to import tests

~/code/matplotlib/lib/matplotlib/transforms.py in ()
33 import numpy as np
34 from numpy import ma
---> 35 from matplotlib._path import (affine_transform, count_bboxes_overlapping_bbox,
36 update_path_extents)
37 from numpy.linalg import inv

ImportError: No module named _path

I implemented a tests within test_colors.py

I don't know it is possible to run the tests in-place (see #2175 )

I would suggest using virtual environments.

The other option is to push your changes to your branch at let travis do the testing for you.

My "test" is a plot that takes a color, lightens and darkens and applies
this to 3 rectangles slightly overlapping to show the variation introduced.
I felt this was satisfactory since the code is mostly for aesthetics.

On Wed, Jan 22, 2014 at 11:59 AM, Thomas A Caswell <notifications@github.com

wrote:

I don't know it is possible to run the tests in-place (see #2175#2175)

I would suggest using virtual environments.

The other option is to push your changes to your branch at let travis do
the testing for you.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2745#issuecomment-33043012
.

It would be better to have a test something like test_colors.test_rgb_hsv_round_trip. It is much faster to run and tests just the thing we care about here (which is that colors get transformed correctly).

@dvreed77 Any chance of this getting these issues addressed in the near future? We are starting the processes of triaging bugs for 1.4 and would like to get this in.

We also need an entry in the change log and whats_new.rst

I will try, been quite busy lately and was a little stumped the last time I
tried to tackle the testing situation. Will get back to you in a few days.

On Mon, Feb 24, 2014 at 11:47 PM, Thomas A Caswell <notifications@github.com

wrote:

@dvreed77 https://github.com/dvreed77 Any chance of this getting these
issues addressed in the near future? We are starting the processes of
triaging bugs for 1.4 and would like to get this in.

We also need an entry in the change log and whats_new.rst

Reply to this email directly or view it on GitHubhttps://github.com//pull/2745#issuecomment-35974669
.

@dvreed77 Any progress on this?

I will work on it this weekend, sorry to be a slacker on this

On Thu, Apr 3, 2014 at 10:23 PM, Thomas A Caswell
notifications@github.comwrote:

@dvreed77 https://github.com/dvreed77 Any progress on this?

Reply to this email directly or view it on GitHubhttps://github.com//pull/2745#issuecomment-39526323
.

Punting this to 1.5.

ping @dvreed77

@tacaswell working on this right now. Can you advise what you think the test should look like. I having trouble figuring this out.

Closing in favor of #8895

@dvreed77 Sorry this sat for so long. If you are still interested in working on this please do, if not, thank you for your work so far.