Added test for tricontour in test_datetime.py #27494
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Thank you for finding this.
It is actually the the goal of doing this exercise to find the places where we think we should support unitful behavior but do not.
It appears that actually current main does not error but also doesn't behave correctly either when handed (at least numpy datetime64 arrays) datetimes. I've opened #27499 to track this problem (along with the other tri* methods)
I will block merging this until the underlying problems are addressed.
| def test_tricontourf(self): | ||
| fig, ax = plt.subplots() | ||
| ax.tricontourf(...) | ||
| def test_tricontour(self): |
There was a problem hiding this comment.
It looks like you wrote the test for tricontour (the unfilled variant), but deleted the stub for tricontourf (the filled variant)
PR summary
This PR addresses the tricontour task in the Increase Unit Test Coverage Issue: #26864.
PR checklist