Skip to content

Micro-optimizations related to list handling #27518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Micro-optimizations related to list handling #27518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/mpl_toolkits/axisartist/axislines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,7 @@ def get_gridlines(self, which="major", axis="both"):
locs.extend(self.axes.xaxis.major.locator())
if which in ("both", "minor"):
locs.extend(self.axes.xaxis.minor.locator())

for x in locs:
gridlines.append([[x, x], [y1, y2]])
gridlines.extend([[x, x], [y1, y2]] for x in locs)

if axis in ("both", "y"):
x1, x2 = self.axes.get_xlim()
Expand All @@ -365,9 +363,7 @@ def get_gridlines(self, which="major", axis="both"):
locs.extend(self.axes.yaxis.major.locator())
if self.axes.yaxis._minor_tick_kw["gridOn"]:
locs.extend(self.axes.yaxis.minor.locator())

for y in locs:
gridlines.append([[x1, x2], [y, y]])
gridlines.extend([[x1, x2], [y, y]] for y in locs)

return gridlines

Expand Down
5 changes: 3 additions & 2 deletions lib/mpl_toolkits/axisartist/grid_finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,16 @@ def _find_line_box_crossings(xys, bbox):
umin, vmin = bbox.min[sl]
umax, vmax = bbox.max[sl]
for u0, inside in [(umin, us > umin), (umax, us < umax)]:
crossings.append([])
cross = []
idxs, = (inside[:-1] ^ inside[1:]).nonzero()
for idx in idxs:
v = vs[idx] + (u0 - us[idx]) * dvs[idx] / dus[idx]
if not vmin <= v <= vmax:
continue
crossing = (u0, v)[sl]
theta = np.degrees(np.arctan2(*dxys[idx][::-1]))
crossings[-1].append((crossing, theta))
cross.append((crossing, theta))
crossings.append(cross)
return crossings


Expand Down