Skip to content

DOC: batch of tags #27567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2024
Merged

DOC: batch of tags #27567

merged 3 commits into from
Sep 16, 2024

Conversation

story645
Copy link
Member

PR summary

Tags from the spreadsheet from #27235 - I'm breaking them up into batches by author to make reviewing easier. These are by @RickyP24, @smcgrawDotNet, and @kakun45

Is waiting on sphinx-tag merging open PRs for supporting content in body of tag.

PR checklist

@story645 story645 added status: upstream fix required Documentation: tags tagging examples + proposing new tags labels Dec 26, 2023
@story645 story645 added this to the v3.9.0 milestone Dec 26, 2023
@story645 story645 force-pushed the tags-sprint branch 9 times, most recently from d9a9fa0 to 0e5e83d Compare December 27, 2023 00:25
@QuLogic QuLogic modified the milestones: v3.9.0, v3.9.1 May 10, 2024
@QuLogic QuLogic modified the milestones: v3.9.1, v3.9.2, v3.9-doc Jun 26, 2024
@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Jul 15, 2024
@QuLogic
Copy link
Member

QuLogic commented Sep 13, 2024

This needs a rebase.

@story645
Copy link
Member Author

Thanks, rebased and cleaned up conflicts. On this one would prefer commits not get squashed to preserve authorship

@story645 story645 force-pushed the tags-sprint branch 2 times, most recently from afda290 to cc5957c Compare September 13, 2024 18:26
@story645 story645 force-pushed the tags-sprint branch 3 times, most recently from bf7b299 to cf798ab Compare September 15, 2024 00:59
@story645
Copy link
Member Author

I think I resolved all comments

@timhoffm timhoffm merged commit 390e146 into matplotlib:main Sep 16, 2024
22 checks passed
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Sep 16, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 390e146c4d30025faf08eac0c9dba97b95dfc1e0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #27567: DOC: batch of tags'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-27567-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR #27567 on branch v3.9.x (DOC: batch of tags)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@QuLogic QuLogic mentioned this pull request Sep 16, 2024
Merged
2 tasks
@QuLogic QuLogic modified the milestones: v3.9-doc, v3.10.0 Sep 16, 2024
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Sep 16, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.2-doc
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 390e146c4d30025faf08eac0c9dba97b95dfc1e0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #27567: DOC: batch of tags'
  1. Push to a named branch:
git push YOURFORK v3.9.2-doc:auto-backport-of-pr-27567-on-v3.9.2-doc
  1. Create a PR against branch v3.9.2-doc, I would have named this PR:

"Backport PR #27567 on branch v3.9.2-doc (DOC: batch of tags)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@QuLogic
Copy link
Member

QuLogic commented Sep 16, 2024

I don't think we're backporting these.

@story645 story645 deleted the tags-sprint branch September 16, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation: examples files in galleries/examples Documentation: tags tagging examples + proposing new tags
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@story645 @QuLogic @timhoffm @kakun45 @smcgrawDotNet @RickyP24