Deprecate cm #27579
Deprecate cm #27579
Conversation
…tions, moved code to pyplot from cm
…ved functions, moved code to pyplot from cm" This reverts commit a8a4f7f.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
This is currently failing tests/linting, which will need to be fixed first. |
| @@ -143,6 +142,10 @@ | |||
| _log = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| _colormaps = ColormapRegistry(_gen_cmap_registry()) | |||
There was a problem hiding this comment.
This didn't need to move here AFAICT.
| @@ -32,22 +32,127 @@ matplotlib.ticker.LogitLocator.nonsingular | |||
| matplotlib.backend_bases._Mode.__new__ | |||
| matplotlib.units.Number.__hash__ | |||
|
|
|||
| # Property read-write vs read-only weirdness, fix if possible | |||
There was a problem hiding this comment.
The additions in this file seem unrelated.
There was a problem hiding this comment.
These look like they are an older version of this file being reintroduced
PR summary
This PR includes the rebase and builds on top of and closes #26965 with @UFEddy 's changes.
Please review carefully.
PR checklist