-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
MNT: fix api changes link in PR template #27641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe this should have been labelled with |
Yeah I didn't label this just to see if the action worked! |
Tried to re-run it, but it's still complaining about the same stuff, so I guess it's pulling from the base commit, and not top of |
is that how it ended up w/ the toolkit label? |
Looks like that one is another minor issue in the config: #27644 |
To me, card feels a bit out of place. Either we regard "API changes" a proper part of the coding guidelines, in which case we should keep the original heading (optionally move that section further down). Or we regard it as a cross-ref hint (think: "if you contribute code, please consider our API changes policy as well"), in which case, I'd go with |
So this change was motivated by the link out to the API guidelines getting kinda buried: I tried a card and I did not like it. Trying a highlight approach now, will post back. |
Changed this PR to just change the link on the PR template so it can go in quickly, moving the docs changes to a different PR |
PR summary
As @QuLogic pointed out in #27310 (comment), the pr template now links to the wrong section so changed that. Also tried making the "go to API changes doc" clearer , but don't love the use of admonitions here.
PR checklist